Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Add Codecov to the workflow #583

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Add Codecov to the workflow #583

merged 3 commits into from
Jun 13, 2022

Conversation

ZeljkoBenovic
Copy link
Contributor

@ZeljkoBenovic ZeljkoBenovic commented Jun 9, 2022

Description

This PR adds Codecov support

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Fixes EDGE-430

@zivkovicmilos
Copy link
Contributor

@ZeljkoBenovic

Are we going to add the codecov.yml file in this PR?

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@6bb316b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #583   +/-   ##
==========================================
  Coverage           ?   51.64%           
==========================================
  Files              ?      109           
  Lines              ?    16045           
  Branches           ?        0           
==========================================
  Hits               ?     8286           
  Misses             ?     7053           
  Partials           ?      706           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ZeljkoBenovic
Copy link
Contributor Author

@ZeljkoBenovic

Are we going to add the codecov.yml file in this PR?

There won't be codecov.yaml file. Everything is in the main workflow, were our tests are.

@ZeljkoBenovic ZeljkoBenovic self-assigned this Jun 9, 2022
@zivkovicmilos
Copy link
Contributor

@ZeljkoBenovic
Are we going to add the codecov.yml file in this PR?

There won't be codecov.yaml file. Everything is in the main workflow, were our tests are.

We don't need the codecov.yaml for the workflow, it's for the reports that it generates on PRs that are opened

Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this feature 🙏

Please look into if we should add the codecov.yaml file.

One small step for man, one giant leap for Polygon Edge

@zivkovicmilos zivkovicmilos added the feature New update to Polygon Edge label Jun 10, 2022
Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeljkoBenovic ZeljkoBenovic merged commit c68f995 into develop Jun 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2022
@zivkovicmilos zivkovicmilos deleted the devops/add-codecov branch June 13, 2022 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants