Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Add linter guards on problematic error checks #652

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Add linter guards on problematic error checks #652

merged 1 commit into from
Jul 26, 2022

Conversation

zivkovicmilos
Copy link
Contributor

Description

This PR introduces some linting fixes.

A notable thing that was added:

  • Protection against Slowris attacks (header timeouts set to 60s)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Additional comments

Fixes EDGE-696

@zivkovicmilos zivkovicmilos added the bug fix Functionality that fixes a bug label Jul 25, 2022
@zivkovicmilos zivkovicmilos self-assigned this Jul 25, 2022
@zivkovicmilos zivkovicmilos added this to the 0.5 milestone Jul 25, 2022
@zivkovicmilos zivkovicmilos merged commit bfc3b94 into develop Jul 26, 2022
@zivkovicmilos zivkovicmilos deleted the fix/linting-errors branch July 26, 2022 08:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZeljkoBenovic ZeljkoBenovic ZeljkoBenovic approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

@dbrajovic dbrajovic Awaiting requested review from dbrajovic

@0xAleksaOpacic 0xAleksaOpacic Awaiting requested review from 0xAleksaOpacic

Assignees

@zivkovicmilos zivkovicmilos

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@zivkovicmilos @Kourin1996 @ZeljkoBenovic