Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Bump the default premine balance #715

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

laviniat1996
Copy link
Contributor

Description

This PR bumps the DefaultPremineBalance from 1000 units of native network currency to 1 million units of native network currency.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have updated the official documentation

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Documentation update

(https://github.com/maticnetwork/matic-docs/pull/1086)

Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats on your first contribution 🚀

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #715 (f1d4514) into develop (c39d854) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #715      +/-   ##
===========================================
- Coverage    52.51%   52.49%   -0.02%     
===========================================
  Files          130      130              
  Lines        17069    17069              
===========================================
- Hits          8964     8961       -3     
- Misses        7462     7464       +2     
- Partials       643      644       +1     
Impacted Files Coverage Δ
network/server_discovery.go 73.88% <0.00%> (-1.92%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@laviniat1996
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@laviniat1996 laviniat1996 merged commit 7ada10f into develop Sep 12, 2022
@zivkovicmilos zivkovicmilos deleted the improvement/default_preminebalance branch October 11, 2022 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants