This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 536
Initial Workflow Rework #765
Merged
epikichi
merged 8 commits into
develop
from
epikichi/edge-868-adopt-changes-into-0xpolygonpolygon-edge
Oct 7, 2022
Merged
Initial Workflow Rework #765
epikichi
merged 8 commits into
develop
from
epikichi/edge-868-adopt-changes-into-0xpolygonpolygon-edge
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epikichi
added
don't merge
Please don't merge this functionality temporarily
feature
New update to Polygon Edge
labels
Sep 27, 2022
ZeljkoBenovic
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🥇
Left some minor comments.
…ng legacy deployer ref
epikichi
requested review from
zivkovicmilos,
lazartravica,
Kourin1996,
dbrajovic,
0xAleksaOpacic and
ferranbt
as code owners
October 4, 2022 20:05
Expected to resolve conflicts from #776 |
vcastellm
reviewed
Oct 5, 2022
vcastellm
reviewed
Oct 5, 2022
vcastellm
reviewed
Oct 5, 2022
vcastellm
reviewed
Oct 5, 2022
vcastellm
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kourin1996
approved these changes
Oct 6, 2022
zivkovicmilos
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
epikichi
deleted the
epikichi/edge-868-adopt-changes-into-0xpolygonpolygon-edge
branch
October 7, 2022 15:31
epikichi
removed
the
don't merge
Please don't merge this functionality temporarily
label
Oct 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a rework to our Github Actions workflows, as shown on our internal RFC. The proper Github environments needs to be set before merging for these workflows to function properly.
Major Workflow Changes
Reusable workflows