-
Notifications
You must be signed in to change notification settings - Fork 536
Automating e2e tests #769
Automating e2e tests #769
Conversation
…rate-e-2-e-consensus-tests-to-edge
Codecov Report
@@ Coverage Diff @@
## develop #769 +/- ##
========================================
Coverage 52.71% 52.72%
========================================
Files 130 130
Lines 17147 17147
========================================
+ Hits 9039 9040 +1
Misses 7460 7460
+ Partials 648 647 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but posting comments with observations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for PR! I've left only suggestions. Please check and change if you feel need. Thank you
Also just another general feedback on e2e framework refactoring, which we can decide later on... On v3, we have introduced abstractions for cluster and bridge and I'd say that looks better than implementing all those functions, which don't belong to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
@Stefan-Ethernal on that observation, the corresponding abstraction to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. 🥇
Left a minor comment.
Description
This is the first of a series of PRs to bring e2e testing to Edge, in this PR we enable automation of running e2e tests with GH actions.
Changes include
Checklist
Testing
Documentation update
Updated
e2e/README.md
Additional comments
One e2e test is failing, now detected because automation, but fixing the test itself is out of the scope of this PR.