This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a pending problem with snapshot pruning, where all snapshots would get pruned out if they incorrectly met the criteria (the snapshot prune selection mechanism didn't take into account that at least one snapshot needs to be left in the snapshot list in-memory).
This problem is only present in PoA networks.
Changes include
Checklist
Testing
Manual tests
Tested manually with a running cluster and small epoch sizes. Additionally, test cases that cover these scenarios have been added.
Additional comments
Fixes EVM-32