Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix to solve a backup stream limit Issue #816

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Hotfix to solve a backup stream limit Issue #816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb2a666
Adding maxHeaderSize const and changing the appendBlock validatation …
eric-gmendes Oct 19, 2022
3182520
Update system_service.go
eric-gmendes Oct 26, 2022
b530f9e
Update system_service.go
eric-gmendes Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/system_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ func (s *systemService) Export(req *proto.ExportRequest, stream proto.System_Exp

const (
defaultMaxGRPCPayloadSize uint64 = 512 * 1024 // 4MB
maxHeaderInfoSize int = 3 * 8 //Number of header fields * bytes per field (From, To, Latest all them uint64)
)

type blockStreamWriter struct {
Expand All @@ -250,8 +251,7 @@ func newBlockStreamWriter(

func (w *blockStreamWriter) appendBlock(b *types.Block) error {
data := b.MarshalRLP()

if uint64(w.buf.Len()+len(data)) >= w.maxPayload {
if uint64(maxHeaderInfoSize+w.buf.Len()+len(data)) >= w.maxPayload {
// send buffered data to client first
if err := w.flush(); err != nil {
return err
Expand Down