Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Remove storage snapshot functions #830

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

ferranbt
Copy link
Contributor

Description

This PR removes the Snapshot functions from the storage which have been long deprecated as far as I can understand.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #830 (f179513) into develop (46a988b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #830      +/-   ##
===========================================
+ Coverage    52.58%   52.59%   +0.01%     
===========================================
  Files          132      132              
  Lines        17523    17523              
===========================================
+ Hits          9214     9217       +3     
+ Misses        7637     7635       -2     
+ Partials       672      671       -1     
Impacted Files Coverage Δ
syncer/client.go 63.20% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a PR even for small stuff

@ferranbt ferranbt merged commit 384ffa2 into develop Oct 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants