EVM 149 - syncer go ibft coordination #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemanja0x
requested review from
zivkovicmilos,
lazartravica,
Kourin1996,
dbrajovic,
0xAleksaOpacic and
ferranbt
as code owners
Kourin1996
reviewed
Oct 27, 2022
Codecov Report
@@ Coverage Diff @@
## go-ibft-integration #843 +/- ##
======================================================
Coverage ? 51.25%
======================================================
Files ? 162
Lines ? 21190
Branches ? 0
======================================================
Hits ? 10860
Misses ? 9483
Partials ? 847 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stefan-Ethernal
changed the title
Stefan-Ethernal
approved these changes
Nov 3, 2022
JekaMas
reviewed
Nov 3, 2022
JekaMas
reviewed
Nov 3, 2022
consensus/polybft/polybft.go
Outdated
| if p.runtime.IsBridgeEnabled() { | ||
| // start bridge event tracker | ||
| if err := p.runtime.startEventTracker(); err != nil { | ||
| return fmt.Errorf("starting event tracker failed:%w", err) |
There was a problem hiding this comment.
nitpicking :) missing a whitespace before %w
JekaMas
reviewed
Nov 3, 2022
JekaMas
reviewed
Nov 3, 2022
consensus/polybft/transport.go
Outdated
| return topic.Subscribe(func(obj interface{}, _ peer.ID) { | ||
| msg, ok := obj.(*pbftproto.TransportMessage) | ||
| if !ok { | ||
| cr.logger.Warn("failed to deliver message", "err", "invalid msg") |
There was a problem hiding this comment.
do we need to log the object itself? also is it a warning or an error?
|
|
||
| return | ||
| } | ||
| // initialize pbft engine |
There was a problem hiding this comment.
Should you remove this commented code?
goran-ethernal
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a initial piece of code required to introduce go-ibft into v3-parity.
The following is implemented:
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Additional comments
In order to split replacement of pbft with go-ibft into a smaller PRs, the tests will not be supported by this PR. The last PR in the incoming sequence of PRs will hold correct e2e tests.