Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking whole files in diff #850

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Checking whole files in diff #850

merged 1 commit into from
Nov 1, 2022

Conversation

vcastellm
Copy link
Contributor

Description

It's the default in golangci-lint action in GH this will bring parity to local linting.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

make lint

Checking whole files in diff
df49f59 
It's the default in golangci-lint action in GH this will bring parity to local linting.
@vcastellm vcastellm added the feature New update to Polygon Edge label Oct 31, 2022
@vcastellm vcastellm self-assigned this Oct 31, 2022
epikichi
epikichi approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@epikichi epikichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a manual Lint workflow

https://github.com/0xPolygon/polygon-edge/actions/runs/3363140335/jobs/5575855935

Passed as expected.

@ferranbt ferranbt merged commit a02bf66 into develop Nov 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
@vcastellm vcastellm deleted the feature/lint-wholefiles branch November 1, 2022 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@epikichi epikichi epikichi approved these changes

@ferranbt ferranbt ferranbt approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

@lazartravica lazartravica Awaiting requested review from lazartravica

@dbrajovic dbrajovic Awaiting requested review from dbrajovic

@0xAleksaOpacic 0xAleksaOpacic Awaiting requested review from 0xAleksaOpacic

@ZeljkoBenovic ZeljkoBenovic Awaiting requested review from ZeljkoBenovic

Assignees

@vcastellm vcastellm

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vcastellm @Kourin1996 @ferranbt @epikichi @Stefan-Ethernal