Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform jsonrpc type return #873

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Conversation

ferranbt
Copy link
Contributor

@ferranbt ferranbt commented Nov 5, 2022

Description

This PR use the return types in the jsonrpc package instead of an explicit conversion inside the endpoint.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@ferranbt ferranbt changed the title Ferranbt uniform jsonrpc type return Uniform jsonrpc type return Nov 5, 2022
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, although unit tests are failing, because it is needed to change assertions (due to changes in return types string vs arg...
https://github.com/0xPolygon/polygon-edge/actions/runs/3401432822/jobs/5677755750

@ferranbt
Copy link
Contributor Author

ferranbt commented Nov 7, 2022

Overall looks good to me, although unit tests are failing, because it is needed to change assertions (due to changes in return types string vs arg...

Thank you! I did fail before due to the multi-lock error so I missed this error.

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferranbt ferranbt merged commit 8e732ad into develop Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the ferranbt-uniform-jsonrpc-type-return branch November 10, 2022 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants