Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epikichi/edge 964 implement multiple erc mode support #954

Merged

Conversation

epikichi
Copy link
Contributor

Description

Adding support for ERC20 and ERC721 in Pandora's Box performance testing worfklow. Users can additionally select the specific mode when calling Pandora's Box workflow_dispatch .

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #954 (f41ae48) into develop (f80b615) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #954      +/-   ##
===========================================
+ Coverage    52.89%   52.91%   +0.01%     
===========================================
  Files          129      129              
  Lines        17113    17113              
===========================================
+ Hits          9052     9055       +3     
+ Misses        7413     7411       -2     
+ Partials       648      647       -1     
Impacted Files Coverage Δ
syncer/client.go 63.20% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ZeljkoBenovic ZeljkoBenovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@epikichi epikichi merged commit 01014e8 into develop Nov 22, 2022
@epikichi epikichi deleted the epikichi/edge-964-implement-multiple-erc-mode-support branch November 22, 2022 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants