Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in container build/push step #977

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

epikichi
Copy link
Contributor

Description

Adding container build/push step to deployment workflows to private ECRs for internal validation.

@epikichi epikichi self-assigned this Nov 28, 2022
@epikichi epikichi changed the title adding in container build/push step Adding in container build/push step Nov 29, 2022
Copy link
Contributor

@trimixlover trimixlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #977 (8342f37) into develop (4eafc19) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #977   +/-   ##
========================================
  Coverage    53.88%   53.88%           
========================================
  Files          132      132           
  Lines        17564    17564           
========================================
  Hits          9465     9465           
  Misses        7451     7451           
  Partials       648      648           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epikichi epikichi merged commit f718aac into develop Dec 8, 2022
@epikichi epikichi deleted the epikichi/edge-902-pre-release-image-deployments branch December 8, 2022 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants