Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint submission e2e test #990

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Dec 1, 2022

Description

This PR implements basic use case for checkpoint submission, which checks whether epoch ending block was checkpointed succesfully.

It also fixes a bug in rootchain init-contracts command, since validators info wasn't resolved correctly (i.e. wrong directory was resolved).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@9e4ec91). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity     #990   +/-   ##
====================================================
  Coverage                     ?   55.24%           
====================================================
  Files                        ?      167           
  Lines                        ?    22432           
  Branches                     ?        0           
====================================================
  Hits                         ?    12393           
  Misses                       ?     9058           
  Partials                     ?      981           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-91-full-feature-e-2-e-success-path-test branch 3 times, most recently from 6769050 to f5d8d2e Compare December 8, 2022 11:50
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-91-full-feature-e-2-e-success-path-test branch from f5d8d2e to e668da6 Compare December 8, 2022 18:58
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-91-full-feature-e-2-e-success-path-test branch from 4b2db88 to b67b65a Compare December 8, 2022 20:24
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review December 8, 2022 21:27
@Stefan-Ethernal Stefan-Ethernal merged commit 74cbed3 into feature/v3-parity Dec 9, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-91-full-feature-e-2-e-success-path-test branch December 9, 2022 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants