-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pending checkpoints submission #992
Fix pending checkpoints submission #992
Conversation
8bbc3b8
to
fd38265
Compare
Can we include any unit test or e2e test to prevent this? |
Sure I meant to implement a unit test, although haven't yet made it. Stay tuned 🙂 |
Sorry I thought it was ready for review! |
93d3a67
to
0c79623
Compare
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #992 +/- ##
====================================================
Coverage ? 55.23%
====================================================
Files ? 167
Lines ? 22421
Branches ? 0
====================================================
Hits ? 12384
Misses ? 9056
Partials ? 981 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
34d386c
to
57f0425
Compare
Description
This PR fixes epoch ending blocks detection for submitting pending checkpoints. Prior to this change, for first pending checkpoint block, we were checkpointing epoch-beginning instead of epoch-ending block.
Changes include
Checklist
Testing