Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pending checkpoints submission #992

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Dec 2, 2022

Description

This PR fixes epoch ending blocks detection for submitting pending checkpoints. Prior to this change, for first pending checkpoint block, we were checkpointing epoch-beginning instead of epoch-ending block.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-261-fix-pending-checkpoints-detection branch from 8bbc3b8 to fd38265 Compare December 2, 2022 08:32
@Stefan-Ethernal Stefan-Ethernal self-assigned this Dec 2, 2022
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Dec 2, 2022
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review December 2, 2022 10:24
@ferranbt
Copy link
Contributor

ferranbt commented Dec 2, 2022

Can we include any unit test or e2e test to prevent this?

@Stefan-Ethernal
Copy link
Collaborator Author

Stefan-Ethernal commented Dec 2, 2022

Can we include any unit test or e2e test to prevent this?

Sure I meant to implement a unit test, although haven't yet made it. Stay tuned 🙂

@Stefan-Ethernal Stefan-Ethernal marked this pull request as draft December 2, 2022 16:37
@ferranbt
Copy link
Contributor

ferranbt commented Dec 2, 2022

Sure I meant to implement a unit test, although haven't yet made it. Stay tuned

Sorry I thought it was ready for review!

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-261-fix-pending-checkpoints-detection branch from 93d3a67 to 0c79623 Compare December 5, 2022 11:34
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@16463dd). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity     #992   +/-   ##
====================================================
  Coverage                     ?   55.23%           
====================================================
  Files                        ?      167           
  Lines                        ?    22421           
  Branches                     ?        0           
====================================================
  Hits                         ?    12384           
  Misses                       ?     9056           
  Partials                     ?      981           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-261-fix-pending-checkpoints-detection branch from 34d386c to 57f0425 Compare December 5, 2022 13:05
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review December 5, 2022 13:19
@Stefan-Ethernal Stefan-Ethernal merged commit 49ae19d into feature/v3-parity Dec 6, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-261-fix-pending-checkpoints-detection branch December 6, 2022 11:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants