You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We often test across different versions of erigon at this point. It would be ideal if a single version of the configuration file could be used with different versions of erigon even if some settings in the file don't exist. But right now if you have a setting in the config.yaml that isn't recognized, erigon won't start. E.g.:
failed setting config flags from yaml/toml file: failed setting zkevm.l1-finalized-block-requirement flag with value=0 error=no such flag -zkevm.l1-finalized-block-requirement
Implementation
I don't have a strong point of view here and am okay if we keep the current behavior. It would make testing easier if when cdk-erigon encounters an unrecognized setting, it logs a warning and continues on.
The text was updated successfully, but these errors were encountered:
There are some settings in our file that seems specific to the newer
versions of cdk-erigon. It would be great if this didn't break
anything, but it does:
0xPolygonHermez/cdk-erigon#1262
Rationale
We often test across different versions of erigon at this point. It would be ideal if a single version of the configuration file could be used with different versions of erigon even if some settings in the file don't exist. But right now if you have a setting in the config.yaml that isn't recognized, erigon won't start. E.g.:
Implementation
I don't have a strong point of view here and am okay if we keep the current behavior. It would make testing easier if when cdk-erigon encounters an unrecognized setting, it logs a warning and continues on.
The text was updated successfully, but these errors were encountered: