Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warnings for unknown configurations #1262

Closed
praetoriansentry opened this issue Oct 2, 2024 · 0 comments · Fixed by #1282
Closed

Emit warnings for unknown configurations #1262

praetoriansentry opened this issue Oct 2, 2024 · 0 comments · Fixed by #1282
Assignees
Labels
good first issue Good for newcomers

Comments

@praetoriansentry
Copy link

Rationale

We often test across different versions of erigon at this point. It would be ideal if a single version of the configuration file could be used with different versions of erigon even if some settings in the file don't exist. But right now if you have a setting in the config.yaml that isn't recognized, erigon won't start. E.g.:

failed setting config flags from yaml/toml file: failed setting zkevm.l1-finalized-block-requirement flag with value=0 error=no such flag -zkevm.l1-finalized-block-requirement

Implementation

I don't have a strong point of view here and am okay if we keep the current behavior. It would make testing easier if when cdk-erigon encounters an unrecognized setting, it logs a warning and continues on.

@revitteth revitteth added the good first issue Good for newcomers label Oct 7, 2024
praetoriansentry added a commit to 0xPolygon/kurtosis-cdk that referenced this issue Oct 7, 2024
There are some settings in our file that seems specific to the newer
versions of cdk-erigon. It would be great if this didn't break
anything, but it does:
0xPolygonHermez/cdk-erigon#1262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
3 participants