Fix tx order in zkevm_getBatchByNumber endpoint response #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
added
cherry-picked
ToniRamirezM
approved these changes
Aug 5, 2024
tclemos
approved these changes
Aug 5, 2024
agnusmor
added a commit
that referenced
this pull request
Aug 14, 2024
agnusmor
added a commit
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes when calling zkevm_getBatchByNumer, it does not return the transactions of the requested batch in an ordered manner. This PR fixes the sorting of the transactions of the batch by the tx_index field (state.receipt table)
Reviewers
Main reviewers:
@tclemos
@ToniRamirezM
@ARR552