support agent revocation status; refactring resolve opts #103

ilya-korotya · 2023-07-19T14:21:04Z

No description provided.

ilya-korotya · 2023-07-19T14:32:29Z

Flow tested after the code refactoring:

vmidyllic · 2023-07-19T14:44:50Z

@ilya-korotya skip revocation option is supported on sdk level and allows not to include revocation info into the circuits, so zkp will be generated without checks for non-revocation of credentials.
At this moment JS SDK will not generate proof on revoked credential despite the option skip revocation

Kolezhniuk · 2023-07-19T14:27:41Z

src/credentials/credential-wallet.ts

+    if (!cred.credentialSubject.id) {
+      userDID = issuerDID;
+    } else {
+      try {


I would remove this try catch because DID.parse throws custom error and code flows looks more clearly

Kolezhniuk · 2023-07-19T14:30:19Z

src/credentials/credential-wallet.ts

+      issuerDID,
+      userDID
+    };
+    return await this.getRevocationStatus(cred.credentialStatus, opts);


you can ommit await here

Kolezhniuk · 2023-07-19T14:31:01Z

src/credentials/credential-wallet.ts

-      issuer: issuerDID,
-      issuerData: issuerData
-    });
+    const cs = await statusResolver.resolve(credStatus, credentialStatusResolveOptions);


Suggested change

const cs = await statusResolver.resolve(credStatus, credentialStatusResolveOptions);

return statusResolver.resolve(credStatus, credentialStatusResolveOptions);

Kolezhniuk · 2023-07-19T14:31:42Z

src/credentials/status/agent-revocation.ts

+import { MediaType, PROTOCOL_MESSAGE_TYPE } from '../../iden3comm/constants';
+import * as uuid from 'uuid';
+
+export class AgentResolver implements CredentialStatusResolver {


add JSDoc comment to all public members for documentation generation

Kolezhniuk · 2023-07-19T14:36:06Z

src/credentials/status/agent-revocation.ts

+      }
+    });
+    const agentResponse = await response.json();
+    return Object.assign(new RevocationStatusAgent(), { agentResponse }).toRevocationStatus();


refactor this similar to https://github.com/0xPolygonID/js-sdk/pull/71/files#diff-6dda80ceab42177e7ebd419e744899cae9a975c7da4a9d9c152d6d5735233104R5-R41

Kolezhniuk · 2023-07-19T14:37:34Z

src/credentials/status/agent-revocation.ts

+  const revocationStatusRequestMessage: RevocationStatusRequestMessage = {
+    id: uuid.v4(),
+    typ: MediaType.PlainMessage,
+    type: PROTOCOL_MESSAGE_TYPE.REVOCATION_STATUS_REQUEST_MESSAGE_TYPE,
+    body: {
+      revocation_nonce: revocationNonce
+    },
+    thid: uuid.v4(),
+    from: from,
+    to: to
+  };
+  return revocationStatusRequestMessage;


Suggested change

const revocationStatusRequestMessage: RevocationStatusRequestMessage = {

id: uuid.v4(),

typ: MediaType.PlainMessage,

type: PROTOCOL_MESSAGE_TYPE.REVOCATION_STATUS_REQUEST_MESSAGE_TYPE,

body: {

revocation_nonce: revocationNonce

},

thid: uuid.v4(),

from: from,

to: to

};

return revocationStatusRequestMessage;

return {

id: uuid.v4(),

typ: MediaType.PlainMessage,

type: PROTOCOL_MESSAGE_TYPE.REVOCATION_STATUS_REQUEST_MESSAGE_TYPE,

body: {

revocation_nonce: revocationNonce

},

thid: uuid.v4(),

from: from,

to: to

}

Kolezhniuk · 2023-07-19T14:39:37Z

src/credentials/status/agent-revocation.ts

+  return revocationStatusRequestMessage;
+}
+
+class RevocationStatusAgent {


any sense to keep this as class instead of creating function something like

toRevocationStatus(agentResponse: RevocationStatusResponseMessage): RevocationStatus { return { mtp: agentResponse.body.mtp, issuer: agentResponse.body.issuer } }

??

Analog of DTO implementation

Kolezhniuk · 2023-07-19T14:41:39Z

src/credentials/status/resolver.ts

+  CredentialStatusType
+} from '../../verifiable';
+
+export type CredentialStatusResolveOptions = {


let's keep it as interface to be more consistent in the project

Kolezhniuk · 2023-07-19T14:46:40Z

src/proof/proof-service.ts

+      if (!credential.credentialSubject.id) {
+        userDID = issuerDID;
+      } else {
+        try {


Also don't see a reason wrapping this with try/catch

Kolezhniuk · 2023-07-19T14:48:08Z

tests/rhs/rhs.test.ts

@@ -262,7 +262,7 @@ describe('rhs', () => {
    await idWallet.publishStateToRHS(issuerDID, rhsUrl);

    const rhsResolver = new RHSResolver(mockStateStorageForDefinedState);
-    const rhsStatus = await rhsResolver.resolve(credRHSStatus, { issuer: issuerDID });
+    const rhsStatus = await rhsResolver.resolve(credRHSStatus, { issuerDID: issuerDID });


Suggested change

const rhsStatus = await rhsResolver.resolve(credRHSStatus, { issuerDID: issuerDID });

const rhsStatus = await rhsResolver.resolve(credRHSStatus, { issuerDID });

support agent revocation status; refactring resolve opts

0f8d1ae

ilya-korotya requested review from Kolezhniuk and vmidyllic July 19, 2023 14:21

Kolezhniuk requested changes Jul 19, 2023

View reviewed changes

fix comments

688ad15

ilya-korotya requested a review from Kolezhniuk July 19, 2023 17:02

Kolezhniuk approved these changes Jul 20, 2023

View reviewed changes

vmidyllic approved these changes Jul 20, 2023

View reviewed changes

ilya-korotya merged commit 7d7b193 into main Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support agent revocation status; refactring resolve opts #103

support agent revocation status; refactring resolve opts #103

ilya-korotya commented Jul 19, 2023

ilya-korotya commented Jul 19, 2023 •

edited

Loading

vmidyllic commented Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

ilya-korotya Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

Kolezhniuk Jul 19, 2023

	const cs = await statusResolver.resolve(credStatus, credentialStatusResolveOptions);
	return statusResolver.resolve(credStatus, credentialStatusResolveOptions);

	const rhsStatus = await rhsResolver.resolve(credRHSStatus, { issuerDID: issuerDID });
	const rhsStatus = await rhsResolver.resolve(credRHSStatus, { issuerDID });

support agent revocation status; refactring resolve opts #103

support agent revocation status; refactring resolve opts #103

Conversation

ilya-korotya commented Jul 19, 2023

ilya-korotya commented Jul 19, 2023 • edited Loading

vmidyllic commented Jul 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilya-korotya commented Jul 19, 2023 •

edited

Loading