Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkLibrary Miden package support; Move Package to miden-package crate in the VM repo #349

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

LinkLibrary Miden package support; Move Package to miden-package crate in the VM repo #349

wants to merge 1 commit into from
+431 −793

Conversation

greenhat
Copy link
Contributor

@greenhat greenhat commented Oct 25, 2024 •
edited
Loading

Ref #346

TODO:

  • extract Package into new miden-package crate in the VM repo;
  • move MastArtifact to miden-package;
  • link Package as LinkLibrary::Masp;

@greenhat greenhat mentioned this pull request Oct 25, 2024
Draft
7 tasks
@greenhat greenhat force-pushed the greenhat/i346-link-lib-package branch 2 times, most recently from 4e03159 to 6cd29e1 Compare October 30, 2024 08:49
Base automatically changed from greenhat/i314-note-script-compilation to next October 30, 2024 09:16
@greenhat greenhat changed the title [4/x] Link Miden package; Move Package to miden-package crate in the VM repo Link Miden package; Move Package to miden-package crate in the VM repo Oct 30, 2024
@greenhat greenhat mentioned this pull request Oct 30, 2024
Open
@greenhat greenhat force-pushed the greenhat/i346-link-lib-package branch from 6cd29e1 to e60feb6 Compare November 5, 2024 14:13
@greenhat greenhat changed the title Link Miden package; Move Package to miden-package crate in the VM repo LinkLibrary Miden package support; Move Package to miden-package crate in the VM repo Nov 5, 2024
greenhat referenced this pull request Nov 6, 2024
@bitwalker
chore: disable editorconfig setting playing havoc with zed
edb28b7
@greenhat
refactor!: move Package to miden-package in the VM repo
01e78e5 
Load `LinkLibrary` from a Miden package. Remove `MastArtifact` and use `miden_package::MastArtifact`.
@greenhat greenhat force-pushed the greenhat/i346-link-lib-package branch from e628a40 to 01e78e5 Compare November 13, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@greenhat