Use thiserror in miden-lib and miden-tx
#1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
thiserrorinmiden-libandmiden-txand refactor some error messages to provide better errors and be in line with the guidelines discussed in #966 and #972.Some
InternalError(String)variants where replaced with aCustom { error_msg: Box<str>, source: Option<Box<dyn Error + Send + Sync + 'static>> }variant which allows implementors of traits likeDataStoreandTransactionAuthenticatorto produce errors that are in line with our source-over-display approach. This is a small breaking change for the client cc @igamigo.Some errors couldn't be made source errors because the latest miden-vm where errors implement
core::error::Errorin no-std is not yet published, so I've added them as a TODO here and added a note in #981.closes #972