Implement macro for Digest creation from long hex string
#984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fumuran
requested review from
bobbinth,
PhilippGackstatter and
Mirko-von-Leipzig
igamigo
reviewed
Nov 25, 2024
|
|
||
| // KERNEL V0 PROCEDURES | ||
| // ================================================================================================ | ||
|
|
||
| /// Hashes of all dynamically executed procedures from the kernel 0. | ||
| pub const KERNEL0_PROCEDURES: [Digest; 32] = [ | ||
| // account_vault_add_asset | ||
| digest!(0xa9fe41a58d609bc6, 0xca49c09c352213a4, 0x30f55868815fc5, 0x84f2f2540b3d335e), | ||
| digest_from_hex!("0xc69b608da541fea9a41322359cc049cac55f816858f530005e333d0b54f2f284"), |
There was a problem hiding this comment.
Should there be a test for these macros and its validations? Maybe comparing the old digest macro with the new one as well
There was a problem hiding this comment.
I thought about it, but in fact every test which internally uses the kernel procedures is checking the correctness of this macro, otherwise it will fail. That's why I wasn't sure whether do we need to create a dedicated tests for this macro.
bobbinth
approved these changes
Nov 25, 2024
PhilippGackstatter
approved these changes
Nov 26, 2024
objects/src/lib.rs
Outdated
Comment on lines
87
to
88
| mut hex_bytes: &[u8], | ||
| mut upper_limit: usize, |
There was a problem hiding this comment.
Suggested change
| mut hex_bytes: &[u8], | |
| mut upper_limit: usize, | |
| hex_bytes: &[u8], | |
| upper_limit: usize, |
Nit: These don't need to be mutable.
bobbinth
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
digest_from_hex!macro for convenient creation ofDigestfrom long hex string.Closes: #872