Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move to new version of miden-base #492

Merged
merged 24 commits into from
Aug 26, 2024
Merged

fix: Move to new version of miden-base #492

merged 24 commits into from
Aug 26, 2024

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Aug 23, 2024

This PR migrates miden-client to the new version of miden-base that uses miden-vm v0.10.

Here is a high-level summary of the changes made to the client:

  • Updates the Rust version to 1.80
  • Script compilation method like compile_note_script now receive the source code to compile instead of a ProgramAst.
  • Account and transaction code is now stored as serialized complet objects instead of serializing its parts and building them each query.
  • RPC conversions were updated to the new proto structure.

@igamigo igamigo changed the title fix: Move to new version of miden-base fix: Move to new version of miden-base Aug 23, 2024
@igamigo igamigo added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Aug 23, 2024
@tomyrd tomyrd removed the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Aug 26, 2024
@tomyrd tomyrd marked this pull request as ready for review August 26, 2024 15:52
@tomyrd tomyrd merged commit 6f09747 into next Aug 26, 2024
13 checks passed
@tomyrd tomyrd deleted the igamigo-migrate-base branch August 26, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants