-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix operation batch flags constraints #1495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fixes! Thank you! I left one comment inline.
One simplification idea: we could get rid of |
Or maybe there is a half-way solution where we have a single flag which basically says "add either 4 or 8" groups. In this case, the constraints are also quite a bit simpler, we get rid of 2 columns, and the worst case cost is 3 extra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
The only thing I think that needs to change is the constraint which should be separated in order to guarantee the "all" part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Fixes the operation batch flag constraints, as well as a minor fix in the op group table auxiliary constraints.