Constrain genesis block's state trie. #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
reviewed
Sep 23, 2023
wborgeaud
approved these changes
Sep 26, 2023
Comment on lines
+658
to
+661
| // Connect genesis state root values. | ||
| for (&limb0, &limb1) in pvs.genesis_state_root.iter().zip(&rhs.genesis_state_root) { | ||
| builder.connect(limb0, limb1); | ||
| } |
There was a problem hiding this comment.
Don't we need to also connect lhs.genesis_state_root and pvs.genesis_state_root?
evm/src/fixed_recursive_verifier.rs
Outdated
| let zero = builder.zero(); | ||
| let has_not_parent_block = builder.sub(one, has_parent_block.target); | ||
|
|
||
| // Chack that the genesis block number is 0. |
There was a problem hiding this comment.
Suggested change
| // Chack that the genesis block number is 0. | |
| // Check that the genesis block number is 0. |
evm/src/proof.rs
Outdated
| @@ -118,6 +118,8 @@ pub struct BlockMetadata { | |||
| /// unlike `BlockMetadata`. | |||
| #[derive(Debug, Clone, Default, Deserialize, Serialize)] | |||
| pub struct ExtraBlockData { | |||
| /// The state trie digest of the gensis block. | |||
There was a problem hiding this comment.
Suggested change
| /// The state trie digest of the gensis block. | |
| /// The state trie digest of the genesis block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the TODO in
create_block_proof, this PR checks that the genesis block has a state trie of a predetermined form. The genesis state trie is provided as an input and stored among the public values.@wborgeaud Please let me know if this is what you had in mind for the genesis state trie!