-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased logUp implementation #1235
Conversation
We removed the |
@LindaGuiga @dlubarov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
This PR corresponds to @wborgeaud's implementation of logUp, rebased on the new main.
There are a few changes from the original implementation, as this PR takes into account @ulrich-haboeck's comments on the original PR. The changes are:
Z
polynomial verification, as per the suggestionstotal_num_logUp_entries < char(F)
eval_lookups_checks
->eval_packed_lookups_generic
andeval_lookups_checks_circuit
->eval_ext_lookups_circuit
, to follow suggestions.A couple of comments are not addressed here:
LookupCheckVars
have Vecs whileStarkEvaluationVars
have slices is that in theLookup
case, we do not know the size of thelocal
andnext
values in advance.