Handle additional panics #1250
Merged
Handle additional panics #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborgeaud
approved these changes
Sep 26, 2023
evm/src/generation/mod.rs
Outdated
Comment on lines
220
to
221
| let mut state = GenerationState::<F>::new(inputs.clone(), &KERNEL.code) | ||
| .map_err(|_| anyhow!("Failed to parse all the initial prover inputs"))?; |
There was a problem hiding this comment.
nit: Could also do
.map_err(|err| anyhow!("Failed to parse all the initial prover inputs: {:?}", err))?;to get more info on which ProgramError was thrown. Also applies elsewhere in this PR.
evm/src/util.rs
Outdated
Comment on lines
75
to
79
| if TryInto::<usize>::try_into(u256).is_err() { | ||
| return Err(ProgramError::IntegerTooLarge); | ||
| } | ||
|
|
||
| Ok(u256.as_usize()) |
There was a problem hiding this comment.
nit
Suggested change
| if TryInto::<usize>::try_into(u256).is_err() { | |
| return Err(ProgramError::IntegerTooLarge); | |
| } | |
| Ok(u256.as_usize()) | |
| u256.try_into().map_err(|_| ProgramError::IntegerTooLarge) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly addresses #1247. More specifically, it handles (on the EVM crate):
as_usize()callsexpect()callsU256methods with implicit internal panic (from_big_endian/from_big_endian/div_mod).I haven't changed (unless required from cascade changes) the kernel / tests + interpreter files as those don't matter as much (panic in testing is fine, and the kernel risks of panic would arise during the offline preprocessing phase which would be caught ahead).