Refactor CTL Handling #1629
Merged
Refactor CTL Handling #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
approved these changes
Oct 4, 2024
starky/src/cross_table_lookup.rs
Outdated
Comment on lines
253
to
254
| auxiliary_polys: &[&Option<Vec<F::Extension>>; N], | ||
| auxiliary_polys_next: &[&Option<Vec<F::Extension>>; N], |
There was a problem hiding this comment.
I think these could share the same lifetimes as below
starky/src/cross_table_lookup.rs
Outdated
| @@ -250,7 +250,8 @@ where | |||
|
|
|||
| /// Outputs all the CTL data necessary to prove a multi-STARK system. | |||
| pub fn get_ctl_vars_from_proofs<'a, F, C, const D: usize, const N: usize>( | |||
There was a problem hiding this comment.
nit: the name is slightly misleading now, as we're not passing the multi_proof as arg anymore. What about get_ctl_vars_from_aux_polys?
sai-deng
force-pushed
the
sai/support_optional_table2
branch
from
a54bf6c to
47511bb
Compare
sai-deng
force-pushed
the
sai/support_optional_table2
branch
from
5fb4d2b to
8463eff
Compare
|
@Nashtare I also updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
get_ctl_vars_from_proofsfunction to sync with the circuit version.