merge develop

.github/CODEOWNERS

@@ -5,3 +5,5 @@
 /mpt_trie/ @0xaatif @Nashtare @muursh
 /trace_decoder/ @0xaatif @muursh @Nashtare
 .github/ @0xaatif @atanmarko @muursh @Nashtare
+/vscode-extension @0xaatif
+/evm_arithmetization/src/bin/lsp-server.rs @0xaatif

evm_arithmetization/Cargo.toml

@@ -24,6 +24,7 @@ hex = { workspace = true, optional = true }
 hex-literal.workspace = true
 itertools.workspace = true
 keccak-hash.workspace = true
+line-index = "0.1.1"
 log.workspace = true
 mpt_trie.workspace = true
 num.workspace = true
@@ -47,6 +48,10 @@ starky = { workspace = true, features = ["parallel"] }
 static_assertions.workspace = true
 thiserror.workspace = true
 tiny-keccak.workspace = true
+tokio.workspace = true
+tower-lsp = "0.20.0"
+tracing.workspace = true
+url.workspace = true
 zk_evm_common.workspace = true
 zk_evm_proc_macro.workspace = true
 

evm_arithmetization/src/all_stark.rs

@@ -4,10 +4,8 @@ use std::iter;
 use plonky2::field::extension::Extendable;
 use plonky2::field::types::Field;
 use plonky2::hash::hash_types::RichField;
-use starky::config::StarkConfig;
 use starky::cross_table_lookup::{CrossTableLookup, TableIdx, TableWithColumns};
 use starky::evaluation_frame::StarkFrame;
-use starky::stark::Stark;
 
 use crate::arithmetic::arithmetic_stark;
 use crate::arithmetic::arithmetic_stark::ArithmeticStark;
@@ -69,24 +67,6 @@ impl<F: RichField + Extendable<D>, const D: usize> Default for AllStark<F, D> {
     }
 }
 
-impl<F: RichField + Extendable<D>, const D: usize> AllStark<F, D> {
-    pub(crate) fn num_lookups_helper_columns(&self, config: &StarkConfig) -> [usize; NUM_TABLES] {
-        [
-            self.arithmetic_stark.num_lookup_helper_columns(config),
-            self.byte_packing_stark.num_lookup_helper_columns(config),
-            self.cpu_stark.num_lookup_helper_columns(config),
-            self.keccak_stark.num_lookup_helper_columns(config),
-            self.keccak_sponge_stark.num_lookup_helper_columns(config),
-            self.logic_stark.num_lookup_helper_columns(config),
-            self.memory_stark.num_lookup_helper_columns(config),
-            self.mem_before_stark.num_lookup_helper_columns(config),
-            self.mem_after_stark.num_lookup_helper_columns(config),
-            #[cfg(feature = "cdk_erigon")]
-            self.poseidon_stark.num_lookup_helper_columns(config),
-        ]
-    }
-}
-
 pub type EvmStarkFrame<T, U, const N: usize> = StarkFrame<T, U, N, 0>;
 
 /// Associates STARK tables with a unique index.