Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Arithmetic trace length #454

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix Arithmetic trace length #454

merged 1 commit into from
Jul 30, 2024

Conversation

hratoanina
Copy link
Contributor

The computation of the displayed unpadded Arithmetic trace length was incorrect and gave a number too low.

@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Jul 29, 2024
Nashtare
Nashtare approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hratoanina hratoanina merged commit f24c826 into develop Jul 30, 2024
15 checks passed
@hratoanina hratoanina deleted the fix_arithmetic_trace_len branch July 30, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@muursh muursh Awaiting requested review from muursh muursh is a code owner

Assignees
No one assigned
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hratoanina @Nashtare