convertConfig Tests #703
Merged
convertConfig Tests #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
force-pushed
the
test/convert-config-test
branch
from
5501160
to
e81d52b
Compare
jalextowle
force-pushed
the
test/convert-config-test
branch
from
fc661e9
to
59bd9d9
Compare
fabioberger
approved these changes
Feb 6, 2020
| @@ -2,6 +2,9 @@ const path = require('path'); | |||
|
|
|||
| module.exports = { | |||
| entry: './conversion-tests/conversion_test.ts', | |||
| node: { | |||
| fs: 'empty' | |||
| }, | |||
There was a problem hiding this comment.
Why was this necessary?
There was a problem hiding this comment.
For some reason, we get an error that is close to "cannot resolve "fs" in @0x/dev-utils". After doing some reading, this is actually a bug in webpack and is fixed by adding this line. This is the issue I referred to find this solution: webpack-contrib/css-loader#447. After reading the issue again, I'm going dig into this a bit more on a low-priority cycle, because it seems like there is a better way to fix this.
albrow
suggested changes
Feb 6, 2020
|
Just some small suggestions. Looks pretty good overall. |
jalextowle
force-pushed
the
test/convert-config-test
branch
from
f7bb1d3
to
2980ff0
Compare
albrow
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the
convertConfigfunction that use the new framework.