In @0x/contracts-exchange: Change isValidOrderSignature back to `…

…public` because passing `calldata` to internal functions isn't supported.
0xProject · Apr 19, 2019 · 9d08d67 · 9d08d67
1 parent 28ae8bf
commit 9d08d67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/contracts/exchange/contracts/src/MixinSignatureValidator.sol b/contracts/exchange/contracts/src/MixinSignatureValidator.sol
@@ -121,11 +121,11 @@ contract MixinSignatureValidator is
     /// @param signature Proof that the order has been signed by signer.
     /// @return True if the signature is valid for the given order and signer.
     function isValidOrderSignature(
-        Order calldata order,
+        Order memory order,
         address signerAddress,
-        bytes calldata signature
+        bytes memory signature
     )
-        external
+        public
         view
         returns (bool isValid)
     {

diff --git a/contracts/exchange/contracts/src/interfaces/ISignatureValidator.sol b/contracts/exchange/contracts/src/interfaces/ISignatureValidator.sol
@@ -64,11 +64,11 @@ contract ISignatureValidator {
     /// @param signature Proof of signing.
     /// @return Validity of order signature.
     function isValidOrderSignature(
-        LibOrder.Order calldata order,
+        LibOrder.Order memory order,
         address signerAddress,
-        bytes calldata signature
+        bytes memory signature
     )
-        external
+        public
         view
         returns (bool isValid);
 }