This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 466
Add OrderValidator and WalletOrderValidator signature strategies to Exchange #1774
Merged
dorothy-zbornak
merged 18 commits into
3.0
from
feature/3.0/exchange/order-validator-signature
Apr 19, 2019
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dbe9e7b
In `@0x/contracts-exchange`: Add `SignatureType.OrderValidator` suppo…
dorothy-zbornak 0f122f1
In `@0x/types`: Add `SignatureType.OrderValidator` and `RevertReason.…
dorothy-zbornak 3f3978e
In `@0x/contracts-exchange`: Fix contracts and update tests for `Sign…
dorothy-zbornak 49ea2bb
Ran prettier/linter
dorothy-zbornak d1c84b5
Update changelogs
dorothy-zbornak cba9d44
In `@0x/order-utils`: Add `SignatureOrderValidatorError` to `Exchange…
dorothy-zbornak 6965358
In `@0x/contracts-exchange`: Add `SignatureOrderValidatorError` rich …
dorothy-zbornak f111852
In `@0x/contracts-exchange`: Add revert test cases for `OrderValidato…
dorothy-zbornak ee6dce2
In `@0x/order-utils`: Update changelog.
dorothy-zbornak 1cb22fe
In `@0x/contracts-exchange`: Split off `SignatureType.OrderValidator`…
dorothy-zbornak f46d219
In `@0x/types`: Add `SignatureType.WalletOrderValidator`.
dorothy-zbornak 28f9d2a
In `@0x/order-utils`: Add `SignatureWalletOrderValidatorError`.
dorothy-zbornak a55b519
In `@0x/contracts-exchange`: Add `SignatureType.WalletOrderValidator`…
dorothy-zbornak 4726158
Ran prettier
dorothy-zbornak fd46519
In `@0x/types`: Remove `RevertReason.WalletOrderValidator`.
dorothy-zbornak 9cdba64
Update/fix changelogs in `@0x/contracts-exchange`, `@0x/order-utils`,…
dorothy-zbornak 28ae8bf
In `@0x/contracts-exchange`: Make `isValidOrderSignature` `external` …
dorothy-zbornak 9d08d67
In `@0x/contracts-exchange`: Change `isValidOrderSignature` back to `…
dorothy-zbornak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this actually compiles. Will have to check out the most recent version of Solidity :)