This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Merge development into 3.0 #2174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cate-code Remove duplicate code from staking contracts
* This commit also squashed some bugs in the reference functions. Thankfully, combinatorial testing had our back!
* This commit also squashed some bugs in the reference functions. Thankfully, combinatorial testing had our back!
…tests for batchFillOrders
…uild. This is not a real to update to `payProtocolFee`. Rather, the interface was updated to it's finished state. This will be addressed in my next PR.
…oxy` will fail for non-contract proxies
Sync Rewards + Refactored Reward Vault
This merge resolves conflicts in contracts/* packages and abi-gen Tests in contracts/* are passing Tests in packages/* are failing. The main issue is refactoring the SignedOrder type to conform with the v3 spec. There may be other smaller refactors needed to get tests passing again.
* Exhibit bug in getSimulatedOrderTransferResults * Fix getSimulatedOrderTransferResults * dev-utils/package.json: add quantify_bytecode cmd * Fix typo in log message * Reduce compiler optimization runs In order to reduce the EVM bytecode object length of the DevUtils contract to be under the EIP-170 limit of 24 KB.
Update AssetProxyOwner
xianny
force-pushed
the
merge-development-into-3.0
branch
from
59c126d
to
b9d6cef
Compare
xianny
force-pushed
the
merge-development-into-3.0
branch
from
d64b87e
to
95a8ffb
Compare
xianny
force-pushed
the
merge-development-into-3.0
branch
from
95a8ffb
to
13d2445
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.