This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abandeali1
force-pushed
the
feat/3.0-mainnet-migrations
branch
4 times, most recently
from
November 12, 2019 18:30
4b0c25e
to
0218555
Compare
…d into constructor
abandeali1
force-pushed
the
feat/3.0-mainnet-migrations
branch
from
November 12, 2019 21:54
0218555
to
b8fc84e
Compare
dekz
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DevUtils
to all testnets and updates the artifactZeroExGovernor
to all testnetssol-compiler
that allows the Solidity standard input to be saved. This is used for verifying the contracts on EtherscanZrxVault
address in the staking deployment constantsStaking
artifact to instead useTestStaking
(with the additional functions removed from the ABI). This means that the bytecode in theStaking
artifact will not match what is actually deployed, but it will allow developers to instantiateweth
andzrxVault
in the constructor when deploying onto local testnets (rather than hard coding addresses intoMixinDeploymentConstants
)Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.