This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abandeali1
force-pushed
the
feat/3.0/migrations-patch
branch
2 times, most recently
from
November 18, 2019 23:14
638c4ca
to
e31171a
Compare
fabioberger
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI passes
dekz
approved these changes
Nov 19, 2019
Merge/rebase off development for the build fix. |
abandeali1
force-pushed
the
feat/3.0/migrations-patch
branch
from
November 19, 2019 00:11
4213b29
to
784a033
Compare
hysz
reviewed
Nov 21, 2019
"erc20BridgeProxy": "0xfb2dd2a1366de37f7241c83d47da58fd503e2c64" | ||
"erc20BridgeProxy": "0xfb2dd2a1366de37f7241c83d47da58fd503e2c64", | ||
"uniswapBridge": "0x0000000000000000000000000000000000000000", | ||
"eth2DaiBridge": "0x0000000000000000000000000000000000000000" | ||
}, | ||
"1337": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abandeali1 @dekz do any addresses need to be updated for 1337
?
We updated the coordinator server's dependencies today and it caused some strange bugs. We found that downgrading to version 4.4.0-beta.2
of the migrations package resolved the issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exchange
,DevUtils
,Coordinator
, andForwarder
contracts on all networks.StakingProxy
,Staking
, andZrxVault
contracts on mainnetUniswapBridge
andEth2DaiBridge
on mainnetTesting instructions
Types of changes
Checklist:
[WIP]
if necessary.