This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
@0x/contracts-erc20-bridge-sampler: Generic liquidity provider sampling
#2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
force-pushed
the
feature/erc20-bridge-sampler/liquidity-provider
branch
2 times, most recently
from
a9ca4fd
to
055dedd
Compare
moodlezoup
changed the title
@0x/contracts-erc20-bridge-sampler: Generic liquidity provider sampling
hysz
reviewed
Feb 20, 2020
contracts/erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol
Outdated
Show resolved
Hide resolved
contracts/erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol
Outdated
Show resolved
Hide resolved
contracts/erc20-bridge-sampler/contracts/src/ERC20BridgeSampler.sol
Outdated
Show resolved
Hide resolved
|
I noticed that IERC20BridgeSampler was not amended to implement the new functions ( |
moodlezoup
force-pushed
the
feature/erc20-bridge-sampler/liquidity-provider
branch
from
055dedd
to
11f3ff1
Compare
moodlezoup
force-pushed
the
feature/erc20-bridge-sampler/liquidity-provider
branch
2 times, most recently
from
9a97717
to
a9c8787
Compare
dorothy-zbornak
approved these changes
Feb 21, 2020
hysz
approved these changes
Feb 26, 2020
moodlezoup
force-pushed
the
feature/erc20-bridge-sampler/liquidity-provider
branch
from
a9c8787
to
76491fa
Compare
moodlezoup
deleted the
feature/erc20-bridge-sampler/liquidity-provider
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces
ILiquidityProvider, a common interface that external teams can implement so that their on-chain liquidity can be easily integrated into the bridge sampler contract and thereby 0x API.Adds quote-sampling methods to
ERC20BridgeSamplerto work with this new interface.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.