This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
@0x/contracts-extensions: Maximum gas price contract
#2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
force-pushed
the
feature/extensions/max-gasprice-orders
branch
from
ebf640a
to
9c5ac26
Compare
moodlezoup
changed the title
@0x/contracts-extensions: Maximum gas price contract
jalextowle
approved these changes
Mar 4, 2020
|
|
||
| */ | ||
|
|
||
| pragma solidity ^0.5.16; |
abandeali1
suggested changes
Mar 4, 2020
| /// @dev Checks that the current transaction's gas price is less than | ||
| /// the specified maximum value. | ||
| /// @param data Encodes the maximum gas price. | ||
| function checkGasPrice(bytes calldata data) |
There was a problem hiding this comment.
Why not just take a uint256 here?
There was a problem hiding this comment.
didn't realize that would work 🙈
| */ | ||
|
|
||
| pragma solidity ^0.5.16; | ||
| pragma experimental ABIEncoderV2; |
There was a problem hiding this comment.
I don't think we actually need to use ABIv2 here. I'd just run tests with/without to see if there are any gas differences.
There was a problem hiding this comment.
looks like without is slightly cheaper for the parametrized version
| * Encodes the given stop limit data parameters into StaticCall asset data so that it can be used | ||
| * in a 0x order. | ||
| */ | ||
| export function encodeMaxGasPriceStaticCallData(maxGasPriceContractAddress: string, maxGasPrice?: BigNumber): string { |
There was a problem hiding this comment.
Thank you for writing this helper 🙌
abandeali1
approved these changes
Mar 5, 2020
| external | ||
| view |
There was a problem hiding this comment.
Why did we get rid of view here?
There was a problem hiding this comment.
oops that was a remnant of some tests
moodlezoup
force-pushed
the
feature/extensions/max-gasprice-orders
branch
from
4af2577
to
4900949
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contract includes a parameter-less version which uses a hard-coded max of 20 Gwei, and a version that allows makers to specify a custom max value.
Includes tooling for encoding/decoding the StaticCall asset data, as well as some basic unit tests
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.