-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebSocket RPC methods: subscribeNewHeads, unsubscribe #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
changed the title
Introduce WebSocket RPC methods
Add WebSocket RPC methods: subscribeNewHeads, unsubscribe
Nov 6, 2024
marioiordanov
requested changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
starknet_subscribeNewHeads
andstarknet_unsubscribe
.todo!
.main.rs
which prevented SIGINT from killing Devnet instantly in block-on-interval mode.starknet_getNonce
ordevnet_mint
are no longer supported via WebSocket. Apparently they never should have been, onlystarknet_(un)subscribe
methods should be available via this protocol.main
branch.Development related changes
i64
.rand::random()
to find occurrences of this.JsonRpcHandler
:to_json_rpc_request
allows_method
which checks restrictedness, relying on previously definedis_json_rpc_method_restricted
api
property with asockets
map.Box
ing of enum variants.TooManyBlocksBack
is not tested because I couldn't make it generate 1024 blocks efficiently.Checklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
./scripts/check_spelling.sh
./website/README.md