Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use u64 for Subscription ID #656

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Use u64 for Subscription ID #656

merged 3 commits into from
Dec 10, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Dec 2, 2024

Usage related changes

  • No more negative IDs (not that this was ever an explicit problem)
  • The spec just says the ID should be an integer
  • Precision issue in starknet.js remains, could be removed if we used u32, but u32 is not among starknet-spec types

Development related changes

  • Define SubscriptionId as a type in two places:
    • json_rpc api models
    • test common utils

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC marked this pull request as ready for review December 3, 2024 13:12
@FabijanC FabijanC merged commit dd2e612 into json-rpc-v0.8.0 Dec 10, 2024
1 check passed
@FabijanC FabijanC deleted the subscription-id-u64 branch December 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants