Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy starknet_getStorageProof, remove unused Serialize #659

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Dec 6, 2024

Usage related changes

Development related changes

  • The corresponding type for starknet_getStorageProof is set to be a dummy serde_json::Value since that case should never happen.
  • The input type for starknet_getStorageProof to serve at least as a structure verifier for users wanting to test interaction with this endpoint.
  • Remove unused Serialize derivations on RPC input structs.
  • Define is_forwardable_to_origin to return true for starknet_getStorageProof in case it's called with an old origin block.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC changed the title Add dummy implementation for starknet_getStorageProof Add dummy starknet_getStorageProof, remove unused Serialize Dec 6, 2024
@FabijanC FabijanC marked this pull request as ready for review December 6, 2024 16:09
@FabijanC FabijanC mentioned this pull request Dec 9, 2024
7 tasks
@FabijanC FabijanC merged commit 31b11ac into json-rpc-v0.8.0 Dec 10, 2024
@FabijanC FabijanC deleted the get-storage-proof branch December 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants