Merge pull request #895 from rvilarl/migration/voicegroup

Migration/voicegroup
0xfe · Apr 11, 2021 · 04b6f22 · 04b6f22
2 parents 99651b1 + 4894ded
commit 04b6f22
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/src/voicegroup.js → src/voicegroup.ts b/src/voicegroup.js → src/voicegroup.ts
@@ -1,24 +1,31 @@
 // [VexFlow](http://vexflow.com) - Copyright (c) Mohit Muthanna 2010.
 
+import type { ModifierContext } from './modifiercontext';
 import { Vex } from './vex';
+import { Voice } from './voice';
 
-/** @constructor */
 export class VoiceGroup {
+  protected voices: Voice[];
+  protected modifierContexts: ModifierContext[];
+
   constructor() {
     this.voices = [];
     this.modifierContexts = [];
   }
 
-  // Every tickable must be associated with a voiceGroup. This allows formatters
-  // and preformatters to associate them with the right modifierContexts.
-  getVoices() {
+  /**
+   * Every tickable must be associated with a voiceGroup. This allows formatters
+   * and preformatters to associate them with the right modifierContexts.
+   */
+  getVoices(): Voice[] {
     return this.voices;
   }
-  getModifierContexts() {
+
+  getModifierContexts(): ModifierContext[] {
     return this.modifierContexts;
   }
 
-  addVoice(voice) {
+  addVoice(voice: Voice): void {
     if (!voice) throw new Vex.RERR('BadArguments', 'Voice cannot be null.');
     this.voices.push(voice);
     voice.setVoiceGroup(this);