review comments

0xfe · May 9, 2021 · 14827d2 · 14827d2
1 parent 20c7ee9
commit 14827d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/notehead.ts b/src/notehead.ts
@@ -243,7 +243,7 @@ export class NoteHead extends Note {
   }
 
   // Set notehead to a provided `stave`
-  setStave(stave?: Stave): this {
+  setStave(stave: Stave): this {
     const line = this.getLine();
 
     this.stave = stave;

diff --git a/src/stavenote.ts b/src/stavenote.ts
@@ -424,8 +424,9 @@ export class StaveNote extends StemmableNote {
       if (noteHeadStyle) noteHead.setStyle(noteHeadStyle);
     });
 
-    if (this.stave) {
-      this.note_heads.forEach((head) => head.setStave(this.stave));
+    const stave = this.stave;
+    if (stave) {
+      this.note_heads.forEach((head) => head.setStave(stave));
     }
     this.calcNoteDisplacements();
     return this;