Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rvilarl committed Apr 6, 2021
1 parent ef07e1a commit 5a84a81
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 14 deletions.
5 changes: 1 addition & 4 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
"prettier",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended"
],
"rules": {
"@typescript-eslint/no-inferrable-types": "off"
}
]
},
{
"files": [ "src/**/*.js" ],
Expand Down
14 changes: 7 additions & 7 deletions src/fraction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import { Vex } from './vex';

/** Fraction represents a rational number. */
export class Fraction {
numerator: number = 1;
numerator = 1;

denominator: number = 1;
denominator = 1;

// Cached objects for comparisons
private static __staticFractionA = new Fraction();
Expand Down Expand Up @@ -71,7 +71,7 @@ export class Fraction {
}

/** Sets numerator and denominator. */
set(numerator: number = 1, denominator: number = 1): this {
set(numerator = 1, denominator = 1): this {
this.numerator = numerator;
this.denominator = denominator;
return this;
Expand Down Expand Up @@ -99,7 +99,7 @@ export class Fraction {
}

/** Adds value of another fraction. */
add(param1: Fraction | number = 0, param2: number = 1): this {
add(param1: Fraction | number = 0, param2 = 1): this {
let otherNumerator: number;
let otherDenominator: number;

Expand All @@ -120,7 +120,7 @@ export class Fraction {
}

/** Substracts value of another fraction. */
subtract(param1: Fraction | number = 0, param2: number = 1): this {
subtract(param1: Fraction | number = 0, param2 = 1): this {
let otherNumerator: number;
let otherDenominator: number;

Expand All @@ -141,7 +141,7 @@ export class Fraction {
}

/** Multiplies by value of another fraction. */
multiply(param1: Fraction | number = 1, param2: number = 1): this {
multiply(param1: Fraction | number = 1, param2 = 1): this {
let otherNumerator: number;
let otherDenominator: number;

Expand All @@ -157,7 +157,7 @@ export class Fraction {
}

/** Divides by value of another Fraction. */
divide(param1: Fraction | number = 1, param2: number = 1): this {
divide(param1: Fraction | number = 1, param2 = 1): this {
let otherNumerator: number;
let otherDenominator: number;

Expand Down
4 changes: 2 additions & 2 deletions src/tuning.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import { Flow } from './tables';

/** Tuning implements varies types of tunings for tablature. */
export class Tuning {
protected numStrings: number = 0;
protected numStrings = 0;

protected tuningString: string = '';
protected tuningString = '';

protected tuningValues: number[] = [];

Expand Down
2 changes: 1 addition & 1 deletion tests/tuning_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Tuning } from '../src/tuning';
import { QUnit, test, equal, expect } from './declarations';

export default (function () {
return {
return {
Start: function () {
QUnit.module('Tuning');
test('Standard Tuning', this.standard.bind(this));
Expand Down

0 comments on commit 5a84a81

Please sign in to comment.