preparation for stavenote migration

0xfe · Apr 21, 2021 · 6130c0f · 6130c0f
1 parent aacf4f7
commit 6130c0f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/src/dot.js b/src/dot.js
@@ -104,8 +104,6 @@ export class Dot extends Modifier {
     super();
     this.setAttribute('type', 'Dot');
 
-    this.note = null;
-    this.index = null;
     this.position = Modifier.Position.RIGHT;
 
     this.radius = 2;
@@ -124,6 +122,7 @@ export class Dot extends Modifier {
       this.radius *= 0.5;
       this.setWidth(3);
     }
+    return this;
   }
 
   setDotShiftY(y) {

diff --git a/src/stem.ts b/src/stem.ts
@@ -17,10 +17,10 @@ function L(
 }
 
 export interface StemOptions {
-  stem_down_y_base_offset: number;
-  stem_up_y_base_offset: number;
-  stem_down_y_offset: number;
-  stem_up_y_offset: number;
+  stem_down_y_base_offset?: number;
+  stem_up_y_base_offset?: number;
+  stem_down_y_offset?: number;
+  stem_up_y_offset?: number;
   stemletHeight?: number;
   isStemlet?: boolean;
   hide?: boolean;

diff --git a/src/stemmablenote.ts b/src/stemmablenote.ts
@@ -103,7 +103,8 @@ export abstract class StemmableNote extends Note {
   }
 
   // Get/set the direction of the stem
-  getStemDirection(): number | undefined {
+  getStemDirection(): number {
+    if (!this.stem_direction) throw new Vex.RERR('NoStem', 'No stem attached to this note.');
     return this.stem_direction;
   }
 
@@ -188,8 +189,9 @@ export abstract class StemmableNote extends Note {
   }
 
   // Get the top and bottom `y` values of the stem.
-  getStemExtents(): Record<string, number> | undefined {
-    return this.stem?.getExtents();
+  getStemExtents(): Record<string, number> {
+    if (!this.stem) throw new Vex.RERR('NoStem', 'No stem attached to this note.');
+    return this.stem.getExtents();
   }
 
   /** Gets the `y` value for the top modifiers at a specific `textLine`. */