Skip to content

Commit

Permalink
glyphnote_tests TODOs fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
rvilarl committed Sep 10, 2021
1 parent 29035aa commit 75f6437
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions tests/glyphnote_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,6 @@
//
// GlyphNote Tests

/* eslint-disable */
// @ts-nocheck

// TODO: Factory.GlyphNote()'s third argument should be optional.
// TODO: Factory.RepeatNote()'s second and third arguments should both be optional.
// TODO: Line 42 - Object literal may only specify known properties, and 'options' does not exist in type 'Partial<SystemOptions>'
// TODO: ChordSymbol.addGlyphOrText(text: string[], ...) should instead take a string (not an array)!
// The implementation looks like text is an array, but we are actually just pulling out individual characters from the string.

import { VexFlowTests, TestOptions } from './vexflow_test_helpers';
import { ChordSymbol } from 'chordsymbol';
import { Glyph } from 'glyph';
Expand Down Expand Up @@ -40,7 +31,7 @@ function chordChanges(options: TestOptions): void {
width: 250,
debugFormatter: options.params.debug,
noPadding: options.params.noPadding,
options: { alpha: options.params.alpha },
details: { alpha: options.params.alpha },
});

const score = f.EasyScore();
Expand Down Expand Up @@ -82,7 +73,7 @@ function basic(options: TestOptions): void {
width: 250,
debugFormatter: options.params.debug,
noPadding: options.params.noPadding,
options: { alpha: options.params.alpha },
details: { alpha: options.params.alpha },
});

const score = f.EasyScore();
Expand Down Expand Up @@ -120,7 +111,7 @@ function repeatNote(options: TestOptions): void {
width: 250,
debugFormatter: options.params.debug,
noPadding: options.params.noPadding,
options: { alpha: options.params.alpha },
details: { alpha: options.params.alpha },
});

const score = f.EasyScore();
Expand Down

0 comments on commit 75f6437

Please sign in to comment.