review comments

0xfe · May 1, 2021 · 856d562 · 856d562
1 parent 74a0101
commit 856d562
Showing 1 changed file with 10 additions and 15 deletions.
diff --git a/src/stavemodifier.ts b/src/stavemodifier.ts
@@ -6,26 +6,14 @@
 import { Element } from './element';
 import { Glyph } from './glyph';
 import { Stave } from './stave';
-
+import { Metrics } from './note';
 export interface LayoutMetrics {
   xMin: number;
   xMax: number;
   paddingLeft: number;
   paddingRight: number;
 }
 
-export interface Metrics {
-  totalLeftPx?: number;
-  totalRightPx?: number;
-  width: number;
-  glyphWidth?: number;
-  notePx?: number;
-  modLeftPx?: number;
-  modRightPx?: number;
-  leftDisplacedHeadPx?: number;
-  glyphPx?: number;
-  rightDisplacedHeadPx?: number;
-}
 export interface StaveModifierSpacer {
   getContext(): boolean;
   setStave(): void;
@@ -116,8 +104,15 @@ export class StaveModifier extends Element {
       renderToStave() {
         // do nothing
       },
-      getMetrics(): Metrics {
-        return { width: padding };
+      getMetrics(): Metrics  {
+        return {
+          width: padding,
+          notePx: 0,
+          modLeftPx: 0,
+          modRightPx: 0,
+          leftDisplacedHeadPx: 0,
+          rightDisplacedHeadPx: 0,
+        };
       },
     };
   }