Merge pull request #1148 from ronyeh/fix/noteStructs2

Fix Tests, Remove Partial<...>, Prefer Optional Fields
0xfe · Oct 1, 2021 · 961f26a · 961f26a
2 parents 55a55fd + 3f7d02f
commit 961f26a
Show file tree

Hide file tree

Showing 65 changed files with 926 additions and 1,058 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ Please help test this beta release and [report issues on GitHub](https://github.
   - Examples:
     - `Accidental.CATEGORY` is now `'Accidental'` instead of `'accidentals'`.
     - `Modifier.CATEGORY` is now `'Modifier'` instead of `'none'`.
+- `ChordSymbol.NO_TEXT_FORMAT` was previously named `ChordSymbol.NOTEXTFORMAT`.
 
 # 3.0.9 / 2020-04-21
 

diff --git a/src/accidental.ts b/src/accidental.ts
@@ -102,7 +102,7 @@ export class Accidental extends Modifier {
         prevNote = note;
       }
       if (stave) {
-        const lineSpace = stave.getOptions().spacing_between_lines_px;
+        const lineSpace = stave.getSpacingBetweenLines();
         const y = stave.getYForLine(props.line);
         const accLine = Math.round((y / lineSpace) * 2) / 2;
         accList.push({ y, line: accLine, shift: shiftL, acc, lineSpace });

diff --git a/src/barnote.ts b/src/barnote.ts
@@ -30,7 +30,7 @@ export class BarNote extends Note {
   // Initialized by the constructor via this.setType(type)
   protected type!: BarlineType;
 
-  constructor(type = BarlineType.SINGLE) {
+  constructor(type: string | BarlineType = BarlineType.SINGLE) {
     super({ duration: 'b' });
 
     this.metrics = {