fix grunt reference

0xfe · Dec 5, 2021 · bb7aae6 · bb7aae6
1 parent c3297ce
commit bb7aae6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -263,6 +263,7 @@ export default Vex;`;
     },
     clean: {
       build: { src: [BUILD_DIR] },
+      reference: { src: [REFERENCE_DIR] },
     },
   });
 
@@ -352,8 +353,9 @@ export default Vex;`;
     'Build to reference/.', //
     [
       //
-      'default',
-      'qunit',
+      'clean:reference',
+      'clean:build',
+      'webpack:buildDebugPlusTests',
       'copy:reference',
     ]
   );

diff --git a/tools/visual_regression.sh b/tools/visual_regression.sh
@@ -27,6 +27,9 @@
 # PNG viewer on OSX. Switch this to whatever your system uses.
 # VIEWER=open
 
+# use . as decimal separator
+LC_NUMERIC="en_US.UTF-8"
+
 # Check ImageMagick installation
 command -v convert >/dev/null 2>&1 || { echo >&2 "Error: ImageMagick not found."; exit 1; }
 
@@ -154,7 +157,11 @@ function diff_image() {
   # Calculate the difference metric and store the composite diff image.
   local hash=`compare -metric PHASH -highlight-color '#ff000050' $diff-b.png $diff-a.png $diff-diff.png 2>&1`
 
-  local isGT=`echo "$hash > $THRESHOLD" | bc -l`
+  # Remove scientific notation
+  local hash6=`printf "%.6f" $hash`
+  local THRESHOLD6=`printf "%.6f" $THRESHOLD`
+
+  local isGT=`echo "$hash6 > $THRESHOLD6" | bc -l`
   if [ "$isGT" == "1" ]
   then
     # Add the result to results.text