review changes

0xfe · May 7, 2021 · c273bfb · c273bfb
1 parent dc3d9c8
commit c273bfb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/barnote.ts b/src/barnote.ts
@@ -10,7 +10,7 @@
 
 import { Vex } from './vex';
 import { Note } from './note';
-import { Barline } from './stavebarline';
+import { Barline, BarlineType } from './stavebarline';
 
 export interface BarnoteMetrics {
   widths: Record<string, number>;
@@ -26,7 +26,7 @@ function L(
 export class BarNote extends Note {
   protected metrics: BarnoteMetrics;
   static DEBUG: boolean;
-  protected type!: number;
+  protected type!: BarlineType;
 
   constructor(type = Barline.type.SINGLE) {
     super({ duration: 'b' });
@@ -53,11 +53,11 @@ export class BarNote extends Note {
   }
 
   // Get and set the type of Bar note. `type` must be one of `Vex.Flow.Barline.type`.
-  getType(): number {
+  getType(): BarlineType {
     return this.type;
   }
 
-  setType(type: string | number): this {
+  setType(type: string | BarlineType): this {
     this.type = typeof type === 'string' ? Barline.typeString[type] : type;
 
     // Set width to width of relevant `Barline`.

diff --git a/src/stavebarline.ts b/src/stavebarline.ts
@@ -15,6 +15,7 @@ export enum BarlineType {
   REPEAT_BOTH = 6,
   NONE = 7,
 }
+
 export class Barline extends StaveModifier {
   protected widths: Record<string, number>;
   protected paddings: Record<string, number>;
@@ -31,7 +32,7 @@ export class Barline extends StaveModifier {
     return BarlineType;
   }
 
-  static get typeString(): Record<string, number> {
+  static get typeString(): Record<string, BarlineType> {
     return {
       single: Barline.type.SINGLE,
       double: Barline.type.DOUBLE,
@@ -46,7 +47,7 @@ export class Barline extends StaveModifier {
   /**
    * @constructor
    */
-  constructor(type: number | string) {
+  constructor(type: BarlineType | string) {
     super();
     this.setAttribute('type', 'Barline');
     this.thickness = Flow.STAVE_LINE_THICKNESS;