Tickable.addModifier() has the same API as Note.addModifier() to avoid

unnecessary casts.
0xfe · Jan 30, 2022 · d59cff5 · d59cff5
1 parent 3f1bb51
commit d59cff5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/note.ts b/src/note.ts
@@ -548,7 +548,7 @@ export abstract class Note extends Tickable {
     }
     modifier.setNote(this);
     modifier.setIndex(index);
-    super.addModifier(modifier, index);
+    super.addModifier(modifier);
     return this;
   }
 

diff --git a/src/tickable.ts b/src/tickable.ts
@@ -274,12 +274,11 @@ export abstract class Tickable extends Element {
 
   /**
    * Optional, if tickable has modifiers, associate a Modifier.
-   * @param index ignored
    * @param mod the modifier
    */
-  // eslint-disable-next-line
-  addModifier(mod: Modifier, index: number = 0): this {
-    this.modifiers.push(mod);
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  addModifier(modifier: Modifier, index: number = 0): this {
+    this.modifiers.push(modifier);
     this._preFormatted = false;
     return this;
   }